[People] People API Improvements for Developers

EncoreDigitalGroup · Nov 28, 2024 · d7821ce · d7821ce
1 parent a0c3b91
commit d7821ce
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 6 deletions.
diff --git a/src/Objects/People/Email.php b/src/Objects/People/Email.php
@@ -42,7 +42,7 @@ public function get(): ClientResponse
     public function forPerson(): ClientResponse
     {
         $http = $this->client()
-            ->get($this->hostname() . Person::PEOPLE_ENDPOINT . "/" . $this->attributes->personId . "/emails");
+            ->get($this->hostname() . Person::PEOPLE_ENDPOINT . "/{$this->attributes->personId}/emails");
 
         $clientResponse = new ClientResponse($http);
 
@@ -58,7 +58,7 @@ public function forPerson(): ClientResponse
     public function update(): ClientResponse
     {
         $http = $this->client()
-            ->patch($this->hostname() . self::EMAIL_ENDPOINT . "/" . $this->attributes->emailAddressId, $this->mapToPco());
+            ->patch($this->hostname() . self::EMAIL_ENDPOINT . "/{$this->attributes->emailAddressId}", $this->mapToPco());
 
         return $this->processResponse($http);
     }

diff --git a/src/Objects/People/Person.php b/src/Objects/People/Person.php
@@ -32,6 +32,13 @@ public static function make(?string $clientId = null, ?string $clientSecret = nu
         return $person;
     }
 
+    public function forPersonId(string $personId): static
+    {
+        $this->attributes->personId = $personId;
+
+        return $this;
+    }
+
     public function all(?array $query = null): ClientResponse
     {
         $http = $this->client()
@@ -51,7 +58,7 @@ public function all(?array $query = null): ClientResponse
     public function get(?array $query = null): ClientResponse
     {
         $http = $this->client()
-            ->get($this->hostname() . self::PEOPLE_ENDPOINT . "/" . $this->attributes->personId, $query);
+            ->get($this->hostname() . self::PEOPLE_ENDPOINT . "/{$this->attributes->personId}", $query);
 
         return $this->processResponse($http);
     }
@@ -67,15 +74,15 @@ public function create(): ClientResponse
     public function update(): ClientResponse
     {
         $http = $this->client()
-            ->patch($this->hostname() . self::PEOPLE_ENDPOINT . "/" . $this->attributes->personId, $this->mapToPco());
+            ->patch($this->hostname() . self::PEOPLE_ENDPOINT . "/{$this->attributes->personId}", $this->mapToPco());
 
         return $this->processResponse($http);
     }
 
     public function delete(): ClientResponse
     {
         $http = $this->client()
-            ->delete($this->hostname() . self::PEOPLE_ENDPOINT . "/" . $this->attributes->personId);
+            ->delete($this->hostname() . self::PEOPLE_ENDPOINT . "/{$this->attributes->personId}");
 
         return $this->processResponse($http);
     }

diff --git a/src/Objects/People/PersonMerger/PersonMerger.php b/src/Objects/People/PersonMerger/PersonMerger.php
@@ -29,10 +29,17 @@ public static function make(string $clientId, string $clientSecret): PersonMerge
         return $personMerger;
     }
 
+    public function forPersonId(string $personId): static
+    {
+        $this->attributes->personMergerId = $personId;
+
+        return $this;
+    }
+
     public function get(?array $query = []): ClientResponse
     {
         $http = $this->client()
-            ->get($this->hostname() . self::PERSON_MERGER_ENDPOINT . "/" . $this->attributes->personMergerId, $query);
+            ->get($this->hostname() . self::PERSON_MERGER_ENDPOINT . "/{$this->attributes->personMergerId}", $query);
 
         return $this->processResponse($http);
     }