Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remodeled application architecture to use webpack to give ability to code in typescript and JSX React #14

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Remodeled application architecture to use webpack to give ability to code in typescript and JSX React #14

merged 1 commit into from
Oct 30, 2024

Conversation

TyMarc
Copy link
Contributor

@TyMarc TyMarc commented Oct 29, 2024

  • Converted the static JSX-less configuration screen to React

@TyMarc TyMarc force-pushed the mahinse/react_scaffold branch from cc91668 to 0f8a3c2 Compare October 29, 2024 18:32
@TyMarc TyMarc self-assigned this Oct 29, 2024
@TyMarc TyMarc marked this pull request as draft October 29, 2024 18:34
@TyMarc TyMarc force-pushed the mahinse/react_scaffold branch from 0f8a3c2 to 9adf538 Compare October 29, 2024 18:37
@TyMarc TyMarc marked this pull request as ready for review October 29, 2024 18:37
@TyMarc TyMarc requested a review from markkasaboski October 29, 2024 18:37
@TyMarc TyMarc changed the title Remodeled application architure to use webpack to give ability to code in typescript and JSX React Remodeled application architecture to use webpack to give ability to code in typescript and JSX React Oct 29, 2024
@TyMarc TyMarc force-pushed the mahinse/react_scaffold branch 4 times, most recently from ec098bf to 96e262e Compare October 30, 2024 19:25
markkasaboski
markkasaboski reviewed Oct 30, 2024
View reviewed changes
@TyMarc TyMarc force-pushed the mahinse/react_scaffold branch 3 times, most recently from e0f4b81 to 3b403be Compare October 30, 2024 19:48
markkasaboski
markkasaboski approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@markkasaboski markkasaboski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few questions

@TyMarc TyMarc force-pushed the mahinse/react_scaffold branch 2 times, most recently from 192292b to c37f09c Compare October 30, 2024 22:57
Remodeled application architure to use webpack to give ability to cod…
3e0c7bf 
…e in typescript and JSX React

- Converted the static JSX-less configuration screen to React
@TyMarc TyMarc force-pushed the mahinse/react_scaffold branch from c37f09c to 3e0c7bf Compare October 30, 2024 23:00
@TyMarc TyMarc merged commit cfd914a into main Oct 30, 2024
2 checks passed
@TyMarc TyMarc deleted the mahinse/react_scaffold branch October 30, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markkasaboski markkasaboski markkasaboski approved these changes

Assignees

@TyMarc TyMarc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TyMarc @markkasaboski