Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes splunk client authentication issue #83

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

markkasaboski
Copy link
Collaborator

@markkasaboski markkasaboski commented Feb 7, 2025

https://gitlab.com/flaresystems/ticket-tracker/-/issues/1683

If a user encounters a Splunk client authentication issue, they will now be able to find this error message in the Splunk internal log. Though, the likelihood of anyone seeing this error is slim. The account of the user who first configured the app will have to have been deleted.

Screenshot 2025-02-07 at 4 19 18 PM

@markkasaboski markkasaboski requested review from TyMarc and aviau February 7, 2025 21:44
@markkasaboski markkasaboski self-assigned this Feb 7, 2025
Copy link

@xvaier xvaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good fix, maybe remove the console log of the username, but otherwise lgtm

@markkasaboski markkasaboski force-pushed the mark/splunk-client-auth branch from 1196a15 to 32cdad0 Compare February 8, 2025 17:00
@markkasaboski markkasaboski merged commit af349c4 into main Feb 10, 2025
2 checks passed
@markkasaboski markkasaboski deleted the mark/splunk-client-auth branch February 10, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants