Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NNlibCUDA v0.1.5 to allow CUDA v3.3.1 #1648

Closed
wants to merge 4 commits into from
Closed

Use NNlibCUDA v0.1.5 to allow CUDA v3.3.1 #1648

wants to merge 4 commits into from

Conversation

DhairyaLGandhi
Copy link
Member

Adds a lower bound to NNlibCUDA so it can pull in CUDA v3.3.1

Will release once CI passes.

@DhairyaLGandhi
Copy link
Member Author

Ah we are finally reporting the failures in the tests! The scalar indexing was quite jarring to look at in the CI.

@ToucheSir
Copy link
Member

ToucheSir commented Jul 2, 2021 •
edited
Loading

Do you know why nightly GHA is still failing? I thought NNlibCUDA v0.1.5 included FluxML/NNlibCUDA.jl#14 and FluxML/NNlibCUDA.jl#15.

@darsnack
Copy link
Member

darsnack commented Jul 2, 2021

Good timing, I just submitted #1651. Hopefully that takes care of it.

@DhairyaLGandhi
Copy link
Member Author

I think we have all of #1651 changes in here.

@ToucheSir ToucheSir mentioned this pull request Jul 2, 2021
Closed
@darsnack
Copy link
Member

darsnack commented Jul 2, 2021

Thanks I missed that.

FluxML/NNlibCUDA.jl#19 should fix the errors in NNlibCUDA.

@DhairyaLGandhi
Copy link
Member Author

DhairyaLGandhi commented Jul 2, 2021 •
edited
Loading

ref FluxML/NNlibCUDA.jl#20 (comment)

We can release a patch but I have added CI for 1.7 as well. That way, if there are lingering qualifications remaining, we can find out without disturbing user code.

@DhairyaLGandhi
Copy link
Member Author

ref JuliaGPU/CUDA.jl#1027

@DhairyaLGandhi
Copy link
Member Author

Great, so we have green CI, and the GPU cases erring as expected - we can mark broken tests and fix them in incoming PRs.

@DhairyaLGandhi DhairyaLGandhi mentioned this pull request Jul 10, 2021
Merged
@mcabbott mcabbott changed the title Release Patch Use NNlibCUDA v0.1.5 to allow CUDA v3.3.1 Jul 10, 2021
@CarloLucibello
Copy link
Member

closing this as it doesn´t seem to be needed after #1657

@CarloLucibello CarloLucibello deleted the dg/bumppathc branch April 7, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DhairyaLGandhi @ToucheSir @darsnack @CarloLucibello