Skip to content

Commit

Permalink
engines node version (#217)
Browse files Browse the repository at this point in the history
* engines node version

* packagemanger version

* upgrade action version per docs

* rm packagemanger version

* versions

* upgrades

* versioning

* version formatting issue

* try to just reinstall

* install

* word
  • Loading branch information
nlkluth authored Jan 10, 2025
1 parent bfe528c commit c22ea7f
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 10 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/code-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ jobs:
name: "Check codebase (lint and typecheck)"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v2
with:
node-version: 18.x

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v4
with:
version: 8
version: 8.15.9

- name: "Get pnpm store directory"
id: pnpm-cache
Expand All @@ -48,16 +48,16 @@ jobs:
name: "Unit Tests"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-node@v2
with:
node-version: 18.x

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v4
with:
version: 8
version: 8.15.9

- name: "Get pnpm store directory"
id: pnpm-cache
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ jobs:
name: E2E Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v4
with:
version: 8
version: 8.15.9

- name: Get pnpm store directory
id: pnpm-cache
Expand Down Expand Up @@ -56,6 +56,10 @@ jobs:
working-directory: packages/shared-ui
run: pnpm build

- name: Reinstall Binary # should probably get cache working if this project is revitalized
run: npx cypress install
working-directory: "packages/tests-e2e"

- name: Cypress Run (Production Backend)
run: pnpm run test:e2e-real:start
# - name: Cypress Run (Mock Backend)
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,8 @@
"*.{js,jsx,ts,tsx,css,md,json}": [
"prettier --write"
]
},
"engines": {
"node": ">=18.0.0"
}
}

0 comments on commit c22ea7f

Please sign in to comment.