-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USDC bridger #335
USDC bridger #335
Conversation
Summary by OctaneNew Contracts
Updated ContractsNo contracts were updated in this PR. 🔗 Commit Hash: 1968a73 |
Overview
Detailed findings
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* @author Game7 Engineering - [email protected] | ||
* @notice This contract is used to bridge USDC to Orbit Chains in a single transaction. | ||
*/ | ||
contract USDCOrbitBridger { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to suggest calling it ERC20Bridger
or SpecificERC20Bridger
but actually I ended up really liking the name USDCBridger
. It's not strictly speaking accurate since you can put any ERC20 token address there, but it works. :)
/** | ||
* @title USDCBridger | ||
* @author Game7 Engineering - [email protected] | ||
* @notice This contract is used to bridge USDC to Orbit Chains in a single transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karacurt : Just add a clarification that it can be used to bridge any specific ERC20 token - not just USDC. This address must be passed during contract construction.
/** | ||
* @title USDCBridger | ||
* @author Game7 Engineering - [email protected] | ||
* @notice This contract is used to bridge any ERC20 token to Orbit Chains in a single transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation is the same as that of ERC20Bridger
. We should note here that, unlike ERC20Bridger
, this contract is for a single ERC20 token, specified when the contract is deployed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.