Directly specify which bundle to use in browser #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome. I'll try to take a look at this later today! Thank you so much! |
DanielJDufour
approved these changes
Oct 2, 2020
|
I just republished a new version with this pull request merged in. Please let me know if it doesn't work. Thank you again for bringing this to my attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
What is the Goal of the PR?
Fix issues with not being able to load the latest version in Angular and other projects
What is the Motivation for the PR?
We need this library in our application, version 0.2.2 works but we'd rather keep up to date with later versions. Trying to import the newest version throws errors similar to #165.
As far as my understanding about webpack and bundling goes (please note, I haven't used those tools directly a lot, so my understanding might be limited), the browser key can be directly set to the script to use. Setting an object is usually used when other modules are required which are not available in the browser, which you can then shim or just completely ignore.
(https://github.com/defunctzombie/package-browser-field-spec)
What Tests are Included?
None