---

GoogleChromeLabs · Jan 28, 2025 · 3b31ef6 · 3b31ef6
1 parent fc3167a
commit 3b31ef6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/bidiServer/BrowserInstance.ts b/src/bidiServer/BrowserInstance.ts
@@ -98,6 +98,7 @@ export class BrowserInstance {
       executablePath,
       args: chromeArguments,
       env: process.env,
+      pipe: true,
     };
 
     debugInternal(`Launching browser`, {
@@ -108,7 +109,7 @@ export class BrowserInstance {
     const browserProcess = launch(launchArguments);
 
     let cdpConnection;
-    if('--remote-debugging-pipe' in chromeArguments) {
+    if(chromeArguments.includes('--remote-debugging-pipe')) {
       cdpConnection = await this.#establishPipeConnection(browserProcess);
     } else {
       const cdpEndpoint = await browserProcess.waitForLineOutput(

diff --git a/tests/webExtension/test_web_extension.py b/tests/webExtension/test_web_extension.py
@@ -38,11 +38,11 @@ async def test_method_not_available(websocket):
 
 @pytest.mark.asyncio
 @pytest.mark.parametrize('capabilities', [{
-    'goog:chromeOptions': {
-        'args': ['--enable-unsafe-extension-debugging', '--remote-debugging-pipe']
-    },
-}],
-                         indirect=True)
+        'goog:chromeOptions': {
+            'args': ['--enable-unsafe-extension-debugging', '--remote-debugging-pipe']
+        },
+    }],
+    indirect=True)
 async def test_invalid_path(websocket):
     with pytest.raises(
             Exception,