-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: webExtension module #3012
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,68 @@ | ||||||
/** | ||||||
* Copyright 2025 Google LLC. | ||||||
* Copyright (c) Microsoft Corporation. | ||||||
* | ||||||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
* you may not use this file except in compliance with the License. | ||||||
* You may obtain a copy of the License at | ||||||
* | ||||||
* http://www.apache.org/licenses/LICENSE-2.0 | ||||||
* | ||||||
* Unless required by applicable law or agreed to in writing, software | ||||||
* distributed under the License is distributed on an "AS IS" BASIS, | ||||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
* See the License for the specific language governing permissions and | ||||||
* limitations under the License. | ||||||
*/ | ||||||
|
||||||
/* | ||||||
* Copyright 2023 Google LLC. | ||||||
* Copyright (c) Microsoft Corporation. | ||||||
* | ||||||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
* you may not use this file except in compliance with the License. | ||||||
* You may obtain a copy of the License at | ||||||
* | ||||||
* http://www.apache.org/licenses/LICENSE-2.0 | ||||||
* | ||||||
* Unless required by applicable law or agreed to in writing, software | ||||||
* distributed under the License is distributed on an "AS IS" BASIS, | ||||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
* See the License for the specific language governing permissions and | ||||||
* limitations under the License. | ||||||
*/ | ||||||
import type {CdpClient} from '../../../cdp/CdpClient.js'; | ||||||
import { | ||||||
InvalidWebExtensionException, | ||||||
type WebExtension, | ||||||
} from '../../../protocol/protocol.js'; | ||||||
|
||||||
/** | ||||||
* Responsible for handling the `storage` module. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
or delete the comment |
||||||
*/ | ||||||
export class WebExtensionProcessor { | ||||||
readonly #browserCdpClient: CdpClient; | ||||||
|
||||||
constructor(browserCdpClient: CdpClient) { | ||||||
this.#browserCdpClient = browserCdpClient; | ||||||
} | ||||||
|
||||||
async install( | ||||||
params: WebExtension.InstallParameters, | ||||||
): Promise<WebExtension.InstallResult> { | ||||||
try { | ||||||
const response = await this.#browserCdpClient.sendCommand( | ||||||
'Extensions.loadUnpacked', | ||||||
{ | ||||||
path: (params.extensionData as WebExtension.ExtensionArchivePath) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for other types, we should throw an Unsupported exception as per spec https://w3c.github.io/webdriver-bidi/#expand-a-web-extension-data-spec you can use a switch statement to cover all possible types of extensionData. |
||||||
.path, | ||||||
}, | ||||||
); | ||||||
return { | ||||||
extension: response.id, | ||||||
}; | ||||||
} catch (err: any) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
instead cast the (error as Error) for type-safety. |
||||||
throw new InvalidWebExtensionException(err.toString()); | ||||||
} | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license is included twice.