Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging as of Ubuntu devel packaging #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

utkarsh2102
Copy link

Hello,

This PR is an initiative to align the Debian packaging of osconfig-agnet in Ubuntu and upstream (here).

The diff represents the changes we have in Ubuntu. I'm forwarding them here as they're all relevant and follow the standard Debian packaging practices. These changes are what we have in Ubuntu devel (current development branch).

These changes change how packaging is done and don't affect the resulting binaries (that is, there is no functional change). Also, it's worth noting that since the Go dependencies have been vendored, it should be sort of ignored while reviewing the PR. Other than that, the changes are small.

Please let me know if you have any questions or concerns.

Copy link

Hi @utkarsh2102. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: utkarsh2102
Once this PR has been reviewed and has the lgtm label, please assign burov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@utkarsh2102
Copy link
Author

@dorileo @a-crate, hey, this is ready for your review! :)

@utkarsh2102 utkarsh2102 force-pushed the update-debian-packaging branch from 19c060e to 1d765b1 Compare September 24, 2024 07:56
@a-crate
Copy link

a-crate commented Sep 24, 2024

Hi Utkarsh, I can't review this one because my team doesn't own this code or this repo. It looks like prow has assigned some reviewers from the OSConfig team though.

@burov burov removed request for dowgird and Gulio October 28, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants