Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grouping feature #1552

Open
wants to merge 26 commits into
base: new-frontend
Choose a base branch
from

Conversation

ImMohammad20000
Copy link
Collaborator

what is new

now you can use groups for better user management
every users have to join to a group

removes

  • remove protocol inbound base system

ImMohammad20000 and others added 20 commits December 11, 2024 15:54
* fix(jobs): not record usages

* fix(webhook): notify user onhold is actvated
* feat(db): increase length of the host and sni columns

* remove unnesserly code
* feat: Add use sni as host

* check if there is any sni
)

* fix: float bug when creating users and showing float data

* update pydantic

* fix: cast reseted_usage and lifetime_used_traffic to int
@ImMohammad20000 ImMohammad20000 added the Feature New feature or request label Dec 30, 2024
@fodhelper
Copy link
Contributor

is it backward compatible with the old API?

@M03ED
Copy link
Collaborator

M03ED commented Jan 2, 2025

is it backward compatible with the old API?

This is gonna be a major update

@fodhelper
Copy link
Contributor

If there be a Default group, new version can accept the old type API Requests but ignore the Inbounds list and put the created user to the Default group
It's not bad to make the API non-strict and backward compatible

@M03ED
Copy link
Collaborator

M03ED commented Jan 2, 2025

If there be a Default group, new version can accept the old type API Requests but ignore the Inbounds list and put the created user to the Default group
It's not bad to make the API non-strict and backward compatible

In that case there might be some conflict after update with creating users with 3rd party projects, I don't think there be a different
At the end you need to update your code

@ImMohammad20000 ImMohammad20000 added the v1 feature or bug that need to be implement or be fixed in version 1 label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Backend Feature New feature or request v1 feature or bug that need to be implement or be fixed in version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants