Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bunch of new features #46

Open
wants to merge 53 commits into
base: develop
Choose a base branch
from
Open

Added bunch of new features #46

wants to merge 53 commits into from

Conversation

kuukunen
Copy link

@kuukunen kuukunen commented May 8, 2020 •
edited
Loading

Hi, I saw this project and thought it did what I wanted, so I started using it. I did find myself wanting some more features though, so I added them.

  • Rename desktops
  • Switch to specific desktop
  • Move window to specific desktop
  • Switch to previous desktop
  • Reset to default settings
  • Bunch of smaller tweaks.

I based the fork on ViRb3's fork, so it also includes the feature to move whole desktops.

Some possible points of interest:

  • ViRb3 removed the UWP support.
  • I bumped the version number quite a bit to make it more clear, but I'm not sure if this is the best way.
  • The renaming doesn't use Windows' desktop naming system (available in Insider Preview) because the API is private and I wasn't quite driven enough to start reverse engineering the COM interface. (There's now VirtualDesktopManagerInternal2 it seems.) Especially since it will probably break and currently only works on the preview anyway.
  • I changed bunch of default shortcuts and added a lot of them too. I saw a lot of features didn't have default shortcuts, I assume on purpose, so again this is debatable.
  • I'm not super fluent in Japanese, but I hope the added translations are ok.
  • I'm not super fluent in C# either and actually this is my first time doing anything with WPF...

ViRb3 and others added 30 commits January 27, 2020 16:40
@ViRb3
Remove UWP support
0c890ac
@ViRb3
Designer language changes
4f968f4
@ViRb3
Add desktop reorder functionality
e376ecb
@ViRb3
Update README
708b6e1
@ViRb3
Bump version
0cd9905
@ViRb3
Add GitHub CI
5a957ad
@ViRb3
Update README
b0e81a6
@ViRb3
Prevent trying to use adjacent desktop if none
124df1d
@ViRb3
Update move desktop default keybinds to avoid conflict
8b80240
@ViRb3
Bump version
5fb2606
@ViRb3
Update README
785378e
@ViRb3
Rework notification windows
08d737d
Add functionality to Move, Switch and Move&Switch to specific desktops.
da280b8 
Combine shortcut settings menus to one.
Bump version mumber.
Add desktop naming functionality.
8cb0221 
Doesn't use the same names as Windows, because the API is hidden and the
feature is currently only available in Insider Preview.
When moving whole desktops, swap the names as well.
4516757
Add "Rename Current" functionality. (Ctrl+Win+R by default.)
3d3fd17
Add Japanese translations to missing items.
1ed5c7f 
Bump version.
Add note to Readme.
e403b6a
Make desktop names list dynamic based on amount of desktops.
a49f12a 
Also fix bunch of problems that came up.
Handle interaction with default switching keys better and add the key…
09a6223 
…s to shortcut menu.

Reorganize settings panels.
Make default shortcuts more consistent.
Add "Reset Settings to Defaults" button.
5650c26
Fix colours so they work in light and dark theme and don't flicker ba…
2edfef3 
…sed on mouse.
Fix rename window sometimes not activating.
80ce132 
Bump version.
Remove Ctrl from swap desktop defaults.
9887852
Add Switch to Previous functionality.
5291791 
Rename "index" to "number" for things like desktop "number" because they
start from 1 and it's confusing.
Style rename window text box.
999a326
Update Readme with info on new features.
44a95eb
Update Readme with features and modified default shortcuts.
c228b86
Readme: Fix line endings.
07d39e9
Readme: Fix more line endings.
e6ad6f4
@maxpavlov
Copy link

@kuukunen great job. Hope this gets merged in soon.

@fadelm0
Copy link

fadelm0 commented May 15, 2020

just throwing this idea here, I don't know if I'll implement it eventually or someone else will

the ability to switch desktop using mouse by clicking on tray icon

@kuukunen kuukunen mentioned this pull request May 19, 2020
Merged
@Poopooracoocoo Poopooracoocoo mentioned this pull request May 19, 2020
Closed
@ViRb3
Copy link

ViRb3 commented May 19, 2020 •
edited
Loading

These changes with some small fixes on top have just been merged and released in my fork (SylphyHornEx).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kuukunen @maxpavlov @fadelm0 @ViRb3 @semantic-release-bot