Swift 6 Compatibility #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this PR still make sense? |
|
Yeah, it still makes sense. Just waiting on the Swift 6.0 PR in the upstream |
|
Looks like Swift 6.0 is finally available with swift-actions/setup-swift? |
NeedleInAJayStack
force-pushed
the
chore/swift-6
branch
from
171c5c3 to
767ca7f
Compare
This test is creates unreliable CI since we can't ensure performance of the runner machine.
|
@xtremekforever Good reminder - thanks! I've rebased this branch, and I think it's ready to go now! Unfortunately I couldn't get rid of all the Swift 6 warnings since we're still targeting a few Swift 5 versions that don't have the replacement APIs. But we should be able to remove those as we push our version support forward over time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes warnings and adds Swift 6 compatibility CI checks.