-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pg create alter table expr translator #3206
Conversation
12a54c0
to
6958abe
Compare
There is a translator called greptime. Is it the mysql protocol? |
I guess it is called a dialect more precisely, instead of a protocol. No matter what we use which protocol in greptime, it always supports the |
I noticed that the translator mod has two submods, one is greptime and the other is postgres. Many of their codes are similar, so I am curious whether there is a dialect of greptime or just MySQL. |
Good point. I renamed the |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3206 +/- ##
==========================================
- Coverage 85.85% 85.38% -0.48%
==========================================
Files 844 847 +3
Lines 138609 138767 +158
==========================================
- Hits 119009 118489 -520
- Misses 19600 20278 +678 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)
#3174
waits for #3203