Branch for review #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back behaviour for search menu
|
The best word is not from the dictionary: 
|
|
Ah, I see this is intended behaviour |
kajigor
reviewed
May 25, 2024
Comment on lines
+11
to
+15
| getLaWordList = getWordList "res/la-dict.txt" | ||
|
|
||
|
|
||
| getTaWordList :: IO [String] | ||
| getTaWordList = getWordList "res/ta-dict.txt" |
There was a problem hiding this comment.
As in other languages, it's better to store the names of the files in a config
Comment on lines
+11
to
+12
| show (WordParseError err word) = "Word '" <> word <> "'. " <> show err | ||
| show (UnknownCommand cmd) = "Unsupported command: '" <> cmd <> "'." |
There was a problem hiding this comment.
Here and everywhere else you want to concatenate strings, it's better to use prinf from Text.Printf. And in general, it's better to use Text
| findBestWord searchDict inputDict = | ||
| let transformedWords = map (\candidate -> (candidate, getColorCountForDict candidate inputDict)) searchDict | ||
| h = head transformedWords | ||
| in if not $ null inputDict then Just $ fst $ foldl (\x y -> |
There was a problem hiding this comment.
Funny enough, there is a notNull function
| let transformedWords = map (\candidate -> (candidate, getColorCountForDict candidate inputDict)) searchDict | ||
| h = head transformedWords | ||
| in if not $ null inputDict then Just $ fst $ foldl (\x y -> | ||
| if compareWords x y == LT then y else x |
There was a problem hiding this comment.
If you provided an instance of Ord for the data type that represents the dictionaries, you could have then used minimum/maximum/sort and other useful standard library functions
| let cnt = fst env | ||
| let lst = snd env | ||
| if ah == eh | ||
| then modify $ const (cnt, (Green, eh) : lst) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.