Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unreliable register nc #567

Open
wants to merge 1 commit into
base: hathorplay-base-release
Choose a base branch
from
Open

fix: unreliable register nc #567

wants to merge 1 commit into from

Conversation

andreabadesso
Copy link
Contributor

Motivation

When registering other wallet's nano contracts, there is a chance the register will miss the caller address because of a memoization problem. This PR should fix it

Acceptance Criteria

  • Stop memoizing ncToAccept

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso changed the base branch from master to hathorplay-base-release September 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexruzenhack alexruzenhack alexruzenhack approved these changes

@pedroferreira1 pedroferreira1 Awaiting requested review from pedroferreira1 pedroferreira1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreabadesso @alexruzenhack