-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concept reuse conflicts ICD10 codes #902
Comments
Thanks @erummas, we'll investigate. For image .2 - a quick look is that we had a test Scan Report that implemented that rule, and was being reused, I've turned this off now. But this is obviously a general concern of ours, as currently effectively one Scan Report poisons the well... so some of our upcoming work will prevent this with more control of what mappings are reused from where. Image .1 might be the same, but I want to check. |
Thanks @AndyRae , yes my concern with image 1 is the incorrect Automated mapping. |
We're having to investigate broadly now - as we follow this through, it looks as though Carrot is behaving as expected. The data in the vocabularies downloaded from Athena does indicate a non-standard to standard mapping exists here, but Athena itself does not. |
Hi @AndyRae are you talking about image 1? The image shared below Non standard to standard mapping on Athena |
@AndyRae it could be a case of vocab versions. If after the mapper upgrade then that could explain the different mappings. I have checked Athena and it states last SNOMED update 01-Feb-2024 |
@erummas versioning is definitely part of what I am trying to understand here. To focus on image 1 as it's easier for me... We're mapping this Concept: https://athena.ohdsi.org/search-terms/terms/45755372 But Carrot shows this as a Standard mapping (but Athena doesn't!): Our current CDM vocabulary shows this non-standard to standard: Note the validity dates - this was introduced back in February.. Vocabulary updates are something of a mystery to me, as I expected them until now to follow the release cycle, with most recent update 30 August. I would note - we fixed a bug where multiple non-standard to standard mappings weren't working - it would just take the first one. This has now been fixed and deployed. |
Hi @AndyRae, you can find the vocabulary release roadmap here https://github.com/OHDSI/Vocabulary-v5.0/wiki/Release-planning |
Is there an existing issue for this?
Current Behavior
Hello, I have observed that the concept reuse is not working fine on the ICD10 codes. sharing screenshots for only two cases
![Image](https://private-user-images.githubusercontent.com/58890026/381550103-864c0aba-ca79-41a9-bf3b-475fd839553a.JPG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDIwOTcsIm5iZiI6MTczOTQ0MTc5NywicGF0aCI6Ii81ODg5MDAyNi8zODE1NTAxMDMtODY0YzBhYmEtY2E3OS00MWE5LWJmM2ItNDc1ZmQ4Mzk1NTNhLkpQRz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDEwMTYzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxMWI0MmY3OTFiZTEwYTgyMjE3YTc5ZTRiMjI0YjAwNjcyZmYyZGUwNTYxZGYzMjk5MzUwMjJjNjI0Nzc0YzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.i26WzshJZsRTKR-arxCGm7nOdh0PwzqqOAB3L3YMF7Y)
In the image above the automated concept_id generated is incorrect (red) and only one of the reuse one is correct(blue)
In the above image the reuse concept id is incorrect and only the automated one is correct
ScanReport No. 701
Expected Behavior
Show only valid mappings
Steps To Reproduce
No response
Environment
I'm part of a Project Team
No response
Anything else?
No response
Are you willing to contribute to resolve this issue?
None
The text was updated successfully, but these errors were encountered: