Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Availability of all standard concept_ids on the mapper #944

Open
1 task done
erummas opened this issue Jan 31, 2025 · 6 comments
Open
1 task done

Availability of all standard concept_ids on the mapper #944

erummas opened this issue Jan 31, 2025 · 6 comments

Comments

@erummas
Copy link

erummas commented Jan 31, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Is your proposal related to a problem or functionality gap?

In OMOP the user is only aware of the source vocabulary. It is particularly difficult to see missing mappings for partially mapped source codes. For example I mapped read code 65EB.00 which maps to concept_id 44792015 (SNOMED) and 40213186 (CVX). Since CVX is not supported on mapper currently this concept failed to show in the rules. I have just been made aware that this is incomplete mapping. There are many other codes showing similar behaviour. It is impossible for the user to know this. The only case where it is obvious is when there is no mapping showing at all.

Describe your proposal

It is very hard for the user to know instantly that there are missing partial mappings. My suggestion to counter this, irrespective of the vocabulary all standard concept_ids made available on the mapper. Or list of vocabularies which contain standard codes be fully imported.

Describe alternatives you've considered

No response

I'm part of a Project Team

No response

Anything else?

No response

Are you willing to contribute to developing this feature?

None

@AndyRae
Copy link
Member

AndyRae commented Feb 2, 2025

Hi @erummas - thanks for this.

Yes an aside - it's in our general plan this year to make it easier to understand the visibility/navigating mappings.

Just to be sure I understand - a short solution of this is to provide all standard vocabs in Carrot?

@erummas
Copy link
Author

erummas commented Feb 4, 2025

Hi @AndyRae, easier solution would be to make all the vocabularies on Athena be made available, downside is that it would require more space on DB. Another solution could be to have full set of current vocabularies (as they are commonly used) and import only standard (S) concept_ids and their associated records from the remaining vocabularies.

@AndyRae
Copy link
Member

AndyRae commented Feb 4, 2025

Thanks - yes my intention was to make all vocabularies available based on the August update, but their data integrity is inconsistent with the CDM. At this point - I'm thinking we wait until the February update, and try again, would that work for your timeline?

@erummas
Copy link
Author

erummas commented Feb 7, 2025

Thank you @AndyRae, that sounds good. Would that be at the end of this month or earlier? I will be needing vocabularies specifically for cancer terms for the dataset I am currently working on. Would be nice to have all vocabularies available on the mapper.

@AndyRae
Copy link
Member

AndyRae commented Feb 7, 2025

@erummas OHDSI do seem to make it the end of the month by the looks of it.

If that's not ideal and you'd prefer it sooner - likely would be this time next week.
I think I'd prefer that, as if it's the end of February when it is released, it means March work for our team which is likely not possible.

@erummas
Copy link
Author

erummas commented Feb 7, 2025

Thank you @AndyRae, earlier works for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants