Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make laser output LASY compliant #1046

Merged

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Dec 10, 2023

This PR makes the laser envelope output of HiPACE++ comply with the openPMD-standard laser envelope extension (https://github.com/openPMD/openPMD-standard/blob/upcoming-2.0.0/EXT_LaserEnvelope.md) used by LASY. Instead of the separate fields laser_real and laser_imag, a single complex field named laserEnvelope is output if it is specified in the input script with:

diagnostic.field_data = laserEnvelope # Ez ExmBy etc.

or

diagnostic.field_data = all
  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added component: diagnostics About any types of diagnostics component: laser envelope About the laser envelope solver labels Dec 11, 2023
@AlexanderSinn AlexanderSinn changed the title [WIP] make laser output LASY compliant Make laser output LASY compliant Dec 17, 2023
@AlexanderSinn AlexanderSinn added the non-backward-compatible Changes the behavior of the code, old input file may give different results label Dec 17, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this PR!

@MaxThevenet
Copy link
Member

WARNING: This PR changes the output format for the laser data, affecting all simulations with a laser pulse.

@MaxThevenet MaxThevenet merged commit 638de3a into Hi-PACE:development Jan 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics About any types of diagnostics component: laser envelope About the laser envelope solver non-backward-compatible Changes the behavior of the code, old input file may give different results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants