-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make laser output LASY compliant #1046
Merged
MaxThevenet
merged 15 commits into
Hi-PACE:development
from
AlexanderSinn:laser_output_LASY_compliant
Jan 3, 2024
Merged
Make laser output LASY compliant #1046
MaxThevenet
merged 15 commits into
Hi-PACE:development
from
AlexanderSinn:laser_output_LASY_compliant
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for this PR!
WARNING: This PR changes the output format for the laser data, affecting all simulations with a laser pulse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: diagnostics
About any types of diagnostics
component: laser envelope
About the laser envelope solver
non-backward-compatible
Changes the behavior of the code, old input file may give different results
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the laser envelope output of HiPACE++ comply with the openPMD-standard laser envelope extension (https://github.com/openPMD/openPMD-standard/blob/upcoming-2.0.0/EXT_LaserEnvelope.md) used by LASY. Instead of the separate fields
laser_real
andlaser_imag
, a single complex field namedlaserEnvelope
is output if it is specified in the input script with:or
const
isconst
)