Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New option to disable the pusher for plasma particles #1203

Merged
merged 10 commits into from
Feb 12, 2025
Merged

New option to disable the pusher for plasma particles #1203

merged 10 commits into from
Feb 12, 2025

Conversation

EyaDammak
Copy link
Contributor

@EyaDammak EyaDammak commented Feb 5, 2025 •
edited
Loading

New plasma and plasmas parameter to disable the particle pusher.
<plasma>.do_push (or <plasmas>.do_push for all species), by default set as True.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@EyaDammak EyaDammak changed the title [WIP] New option to disable the pusher for plasma particles New option to disable the pusher for plasma particles Feb 5, 2025
@EyaDammak EyaDammak added documentation Improvements or additions to documentation component: plasma About the plasma species labels Feb 5, 2025
AlexanderSinn
AlexanderSinn reviewed Feb 5, 2025
View reviewed changes
src/particles/plasma/PlasmaParticleContainer.H Outdated
@@ -195,6 +195,7 @@ public:
amrex::Real m_mass = 0; /**< mass of each particle of this species */
amrex::Real m_charge = 0; /**< charge of each particle of this species, per Ion level */
int m_n_subcycles = 1; /**< number of subcycles in the plasma particle push */
bool m_do_push = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a short comment like it's done for the variables above, in /**< ... */. Also this PR adds two extra newlines in Hipace.cpp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thx

@MaxThevenet MaxThevenet merged commit 4f46952 into Hi-PACE:development Feb 12, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSinn AlexanderSinn AlexanderSinn left review comments

@MaxThevenet MaxThevenet MaxThevenet approved these changes

Assignees
No one assigned
Labels
component: plasma About the plasma species documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EyaDammak @MaxThevenet @AlexanderSinn