-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
To fix the ray error with rpath, I moved the compilers from the build section of requirements to the host section of requirements. The conda documentation says that any shared libraries that you need to link against in your build should be in the host section. This solved the rpath issue. I reordered the build section to be the above the host section for to be consistent across recipes. This PR uses the common build_scripts now for ray-feedstock
Please read the commit message above to understand the change I made. (Because I reordered the two sections, the difference is hard to see) Before and after test with the old/new packages
Comparison of a extract of the conda .tar.bz2 files: ray-0.8.1-py37h1d8a796_1.tar.bz2:
ray-0.8.1-py37h1d8a796_2.tar.bz2:
|
And of course I forgot to update .travis.yaml :( |
To fix the ray error with rpath, I moved the compilers from the build section of requirements to the host section of requirements. The conda documentation says that any shared libraries that you need to link against in your build should be in the host section. This solved the rpath issue. I reordered the build section to be the above the host section for to be consistent across recipes. This PR uses the common build_scripts now for ray-feedstock
…irons/powerai into ray_incorrect_libstdc_linkage
in .travis.yaml, the new way is:
|
.travis.yml
Outdated
os: linux | ||
- env: CONFIG=linux_ppc64le_python3.6 UPLOAD_PACKAGES=True DOCKER_IMAGE=condaforge/linux-anvil-ppc64le | ||
language: generic | ||
os: linux-ppc64le |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just linux
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had cut and pasted the .travis.yml for the last ray PR. Should be fixed now.
Thanks Billy for fixing this. |
Huh. I wonder why we don't see this all over the place. Surely any compiled C++ code must need A bit weird, but if it works, then I'm OK with it. |
Did you try conda run_exports syntax: or shared lib whitelist?: |
Using
I got same Trying whitelist now. |
I'll submit a new PR with a better fix. |
@wdirons @jayfurmanek @hartb looks like related issue? |
To fix the ray error with rpath, I moved the compilers from the build section of
requirements to the host section of requirements. The conda documentation says
that any shared libraries that you need to link against in your build should be
in the host section. This solved the rpath issue.
I reordered the build section to be the above the host section for to be
consistent across recipes.
This PR uses the common build_scripts now for ray-feedstock