-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send Tab to Device from Desktop doesn't show the new tab in Wolvic #1693
Comments
OK, so the bug is not that we don't get the event but that the new tab is not shown on top of the existing ones right? |
Correct. |
I think this is the same behavior that we had before. The new tab showed up when you open the tabs dialog. And it was ok I guess because it is natural to go there to try to find the tab you just sent from another device. But now with the possibility of having the tabs always visible on the side or top of the browser window, the tab never appears. |
But the new received tab is also shown when coming back from sleep mode. |
@javifernandez couldn't this be caused by #1344 ? Did you restart Wolvic after setting up the FxA account? |
Nop, it's reproducible even with a restart |
Yes, I've checked the code and the call to |
As @juanjosanchez said this is not a regression, this has been working like this since FxR times. That said we might want to have refreshes at regular intervals or after other events, that's why we can keep this open |
Would the PR#1722 be a fix for this issue ? Ideally we should be able to receive the Tab without user intervention, like FF in Desktop does. So if we may want to leave this open to pursue that goal. However, users have now an easy way to get the Tab, similarly to how other items (eg, Bookmarsk) are being synchronized. |
Right we forgot to link those issues |
Configuration
Wolvic version: 1.8
Wolvic build ID: 190161443
Hardware: Quest3 SO V71
Steps to Reproduce
Current Behavior
Wolvic remains unchanged, the new tab is not loaded in the main window.
The new tab is shown if the Wolvic app enters in sleep mode and wakes up. It's also shown if the Tabs selection dialog is launched clicking in the corresponding Tray icon.
Expected Behavior
A new Wolvic tab is created and shown in the main window.
Possible Solution
Context
Error Logs and Stack Traces
The text was updated successfully, but these errors were encountered: