Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Tab to Device from Desktop doesn't show the new tab in Wolvic #1693

Closed
javifernandez opened this issue Jan 17, 2025 · 10 comments · Fixed by #1722
Closed

Send Tab to Device from Desktop doesn't show the new tab in Wolvic #1693

javifernandez opened this issue Jan 17, 2025 · 10 comments · Fixed by #1722
Labels
enhancement New feature or request

Comments

@javifernandez
Copy link
Member

Configuration

Wolvic version: 1.8
Wolvic build ID: 190161443

Hardware: Quest3 SO V71

Steps to Reproduce

  1. Launch the centextual menu in a tab of Firefox Desktop
  2. Click on the Send Tab to Device
  3. Select Wolvic on Meta Quest3

Current Behavior

Wolvic remains unchanged, the new tab is not loaded in the main window.

The new tab is shown if the Wolvic app enters in sleep mode and wakes up. It's also shown if the Tabs selection dialog is launched clicking in the corresponding Tray icon.

Expected Behavior

A new Wolvic tab is created and shown in the main window.

Possible Solution

Context

Error Logs and Stack Traces

@svillar
Copy link
Member

svillar commented Jan 17, 2025

OK, so the bug is not that we don't get the event but that the new tab is not shown on top of the existing ones right?

@javifernandez
Copy link
Member Author

OK, so the bug is not that we don't get the event but that the new tab is not shown on top of the existing ones right?

Correct.

@javifernandez javifernandez added the bug Something isn't working label Jan 17, 2025
@juanjosanchez
Copy link
Contributor

I think this is the same behavior that we had before. The new tab showed up when you open the tabs dialog. And it was ok I guess because it is natural to go there to try to find the tab you just sent from another device.

But now with the possibility of having the tabs always visible on the side or top of the browser window, the tab never appears.

@javifernandez
Copy link
Member Author

The new tab showed up when you open the tabs dialog.

But the new received tab is also shown when coming back from sleep mode.

@svillar
Copy link
Member

svillar commented Jan 20, 2025

@javifernandez couldn't this be caused by #1344 ? Did you restart Wolvic after setting up the FxA account?

@svillar
Copy link
Member

svillar commented Jan 20, 2025

@javifernandez couldn't this be caused by #1344 ? Did you restart Wolvic after setting up the FxA account?

Nop, it's reproducible even with a restart

@svillar
Copy link
Member

svillar commented Jan 20, 2025

The new tab showed up when you open the tabs dialog.

But the new received tab is also shown when coming back from sleep mode.

Yes, I've checked the code and the call to ((VRBrowserApplication)mContext.getApplicationContext()).getAccounts().pollForEventsAsync(); is issued in 2 different places, when clicking on the tab widget and also when resuming Wolvic, so what we observe makes total sense.

@svillar svillar added enhancement New feature or request and removed bug Something isn't working labels Jan 20, 2025
@svillar
Copy link
Member

svillar commented Jan 20, 2025

As @juanjosanchez said this is not a regression, this has been working like this since FxR times. That said we might want to have refreshes at regular intervals or after other events, that's why we can keep this open

@javifernandez
Copy link
Member Author

Would the PR#1722 be a fix for this issue ?

Ideally we should be able to receive the Tab without user intervention, like FF in Desktop does. So if we may want to leave this open to pursue that goal. However, users have now an easy way to get the Tab, similarly to how other items (eg, Bookmarsk) are being synchronized.

@svillar
Copy link
Member

svillar commented Jan 30, 2025

Right we forgot to link those issues

@svillar svillar closed this as completed Jan 30, 2025
@svillar svillar linked a pull request Jan 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants