Sync button to receive tabs from FxA #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeerias
force-pushed
the
felipeerias/syncTabsButton
branch
from
5095ffe to
74ee6aa
Compare
|
The idea we had is that the sync button is only visible if the user has been authenticated in the FxA service. |
svillar
requested changes
Jan 27, 2025
felipeerias
force-pushed
the
felipeerias/syncTabsButton
branch
from
74ee6aa to
cd045e7
Compare
Since we do not support push notifications from the FxA service, we need to request an update manually whenever we want to receive shared tabs. This change adds a "refresh" button to the tabs bars. Based on #1718
felipeerias
force-pushed
the
felipeerias/syncTabsButton
branch
from
cd045e7 to
ace5e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we do not support push notifications from the FxA service, we need to request an update manually whenever we want to receive shared tabs.
This change adds a "refresh" button to the tabs bars.
Based on #1718