Custom kbd fixes #1159
Merged
Custom kbd fixes #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do know that the rows field in Keyboard is an ArrayList<Row> so we can safely remove the warning. Instead of suppressing it for the whole method we can convert the if to a ternary operator and use the annotation for a single line as it's done later in the same method.
Several easy unrelated fixes included unused imports, not needed local variables or unneeded null checks.
javifernandez
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several fixes in our CustomKeyboard class being the most relevant one a fix for an unchecked cast that was issuing a warning on every build.
Fixes #1158