Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing in Android widgets without auto compose #1205

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix typing in Android widgets without auto compose #1205

merged 1 commit into from
Jan 29, 2024

Conversation

HollowMan6
Copy link
Collaborator

3c6032c uses CompletableFuture to excute postInputCommand, this actually applies to both auto-compose and non auto-compose. Some code still need to get excuted in the UI thread.

This commit fixes those crashes when typing in Android widgets without auto compose

3c6032c
uses CompletableFuture to excute postInputCommand, this actually
applies to both auto-compose and non auto-compose. Some code
still need to get excuted in the UI thread.

This commit fixes those crashes when typing in Android widgets
without auto compose

Signed-off-by: Hollow Man <[email protected]>
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto-complete code seems a bit weak now. It looks like we should find a better way to process those events without having to specify one by one where they are processed. Anyway this looks necessary so let's land it.

@svillar svillar merged commit 8720589 into main Jan 29, 2024
20 checks passed
@svillar svillar deleted the fix-type branch January 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants