Battery level related changes #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping reviewers |
That method is used to report controllers' battery levels to Java so that their values could be shown in the tray bar. In the case of the Vision Glass the controller is at the same time the VR system (i.e. the phone) so it does not make sense to report any value there. The battery level of the phone is already retrieved from the Java side.
It lacks a "y", it should be named updateBatteryLevels.
When using tethered devices instead of standalone headsets, the battery level we show in the tray is the phone's so it does make sense to use "Phone" instead of "Headset".
svillar
force-pushed
the
vg_battery_level
branch
from
ea1b7f0 to
4f86fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made of 3 changes:
This requires new translations