Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Time picker issue #1258

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix Time picker issue #1258

merged 1 commit into from
Feb 16, 2024

Conversation

mshin-wolvic
Copy link
Collaborator

@mshin-wolvic mshin-wolvic commented Feb 16, 2024

This patch fixes the issue that the date picker instead of the time picker is shown for <input type="time">.

This patch fixes the issue that the date picker instead of the time
picker is shown for <input type="time">.
@svillar
Copy link
Member

svillar commented Feb 16, 2024

This patch fixes the issue that the date picker instead of the time picker is shown for .

Seems like something else is missing. Please add a description of the problem to the commit message. Thanks!

@mshin-wolvic
Copy link
Collaborator Author

Seems like something else is missing. Please add a description of the problem to the commit message. Thanks!

Oop. Done with code format. Thanks!

Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@svillar svillar merged commit 8877dc0 into main Feb 16, 2024
20 checks passed
@svillar svillar deleted the fix_time_picker_only branch February 16, 2024 14:46
@svillar
Copy link
Member

svillar commented Feb 16, 2024

@felipeerias this qualifies for merging into 1.6 WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants