Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GoogleVR leftover #1265

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Remove GoogleVR leftover #1265

merged 2 commits into from
Feb 27, 2024

Conversation

svillar
Copy link
Member

@svillar svillar commented Feb 20, 2024

GoogleVR was supported by FxR at some point but then the support was removed as it was not maintained. This PR removes some of code that was added for GoogleVR but not removed.

As that code was deprecated we added a more modern version of it as part of our effort to remove warnings in the code without realizing that the code was added for an unsupported platform. We're removing that code as well.

GoogleVR was supported by FxR at some point but then the support
was removed as it was not maintained. This PR removes some of
code that was added for GoogleVR but not removed.

As that code was deprecated we added a more modern version of it
as part of our effort to remove warnings in the code without
realizing that the code was added for an unsupported platform.
We're removing that code as well.
@svillar svillar requested a review from felipeerias February 20, 2024 09:55
@svillar svillar requested a review from felipeerias February 21, 2024 11:07
Copy link
Collaborator

@felipeerias felipeerias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svillar svillar merged commit 4cc8c33 into main Feb 27, 2024
20 checks passed
@svillar svillar deleted the googlevr_leftover branch February 27, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants