[chromium] Add NullPointerException in PromptDelegateImpl #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Personally I think it's better to add a null check instead of a try-catch. The reason is because having a null delegate is a valid code path more than an exceptional case, so I prefer to handle it as any other "normal" code path.
You could use this same PR to change the exception check that you added in #1256
This patch adds the null check since `mDelegate` can be null.
mshin-wolvic
force-pushed
the
add_safe_code_for_access_delegate
branch
from
eeeebd2 to
4879b26
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds NullPointerException since
mDelegatecan be null.