Display rationale before requesting a permission #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test website: https://people.igalia.com/femorandeira/permissions/ |
svillar
requested changes
Feb 27, 2024
| @@ -275,7 +300,7 @@ public void reject() { | |||
| } | |||
|
|
|||
| @Override | |||
| public void onMediaPermissionRequest(WSession aSession, String aUri, MediaSource[] aVideo, MediaSource[] aAudio, final MediaCallback aMediaCallback) { | |||
| public void onMediaPermissionRequest(@NonNull WSession aSession, @NonNull String aUri, MediaSource[] aVideo, MediaSource[] aAudio, @NonNull final MediaCallback aMediaCallback) { | |||
There was a problem hiding this comment.
Looks like we could gather all the missing annotations in a separate commit?
felipeerias
force-pushed
the
felipeerias/permissionRationaleDialog
branch
from
1c968c0 to
1211c29
Compare
This is required by HVR in mainland China.
felipeerias
force-pushed
the
felipeerias/permissionRationaleDialog
branch
from
1211c29 to
39a5c40
Compare
svillar
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required by HVR in mainland China.
This is implemented by showing a dialog before the Android API is called.