[VisionGlass] Improve phone UI #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Prevents errors that might appear due to UI elements not being properly initialized or UI layouts not being inflated because the code is trying to initialize the whole VisionGlass system (note that VisionGlass initialization is fundamentally an async process).
svillar
force-pushed
the
vg_improved_phoneui
branch
2 times, most recently
from
e97c863 to
95adffd
Compare
The current architecture of the Activity class is suboptimal. The main class, the VRBrowserActivity, turns out to be a subclass of a PlatformActivity class which is platform specific (because some flavours inherit from different types of Activity). The problem is that we cannot add platform specifics to VRBrowserActivity, but at the same time it's the class that has all the information, so it's complex to do anything meaningful at the PlatformActivity level. In order to do that in a clean way we're adding this new interface which will be implemented and instantiated at the PlatformActivity level. It'll contain the platform specific code, and as it will be used by VRBrowserActivity, it would receive any required information as parametters of the different interface methods. This way we could encapsulate platform specifics at the PlatformActivity level without losing access to the data/methods of the VRBrowserActivity.
Added a new Voice Search button to the phone UI. It's only enabled when the keyboard is shown, i.e., when input is required. Once clicked the handling of the input is directly managed by the KeyboardWidget which properly handles the different types of input (like entering text in a Web page vs entering text in a UI widget).
Media controls were added to the phone UI using the newly added PlatformActivityPlugin architecture. The media playback controls are only shown whenever the web engine detects that a media element is present and hidden as soon as the media element is gone. The controls include play/pause button, mute button, fast forward and fast backward buttons and a progress seekbar. There are some caveats though caused by limitations of the GeckoView API, for example progress information is only issued for fullscreen media.
svillar
force-pushed
the
vg_improved_phoneui
branch
from
95adffd to
d4a0e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some major changes to the Phone UI in the VisionGlass. It's based in two important refactorings:
PlatformActivityPlugininterface that will be called byVRBrowserActivityto perform platform specific tasks. It's needed because the differentPlatformActivitys are superclasses ofVRBrowserActivityand thus don't have access to data and interface implementations of the latter.Once these two are in place the following changes were implemented in the phone UI: