Restore back action using B/Y buttons in non-WebXR mode #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a3f4cb4 we removed the possibility of going back with B/Y buttons because that was interferring with potential action assignments of those buttons inside WebXR experiences. We were exiting the WebXR experience instead of executing the action that was set by authors. However it turns out that these buttons are heavily used by users in non-immersive sessions as they're very convenient as you don't really have to hold both controllers to have full control of your 2D navigation. Fixes #1266
javifernandez
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a3f4cb4 we removed the possibility of going back with B/Y buttons because that was interferring with potential action assignments of those buttons inside WebXR experiences. We were exiting the WebXR experience instead of executing the action that was set by authors.
However it turns out that these buttons are heavily used by users in non-immersive sessions as they're very convenient as you don't really have to hold both controllers to have full control of your 2D navigation.
Fixes #1266