Allow asking the soft keyboard from outside the window widget #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the issue that Chromium doesn't type nothing in the form. The problem was that the focused view notified from the system is not involved in the window widget which the keyboard widget is attached to. Since Chromium has a content view outside of the windows widget's layer, the focus view could be different with the window widget. This patch allows asking the soft keyboard from the out side of the window widget.
svillar
requested changes
Feb 29, 2024
There was a problem hiding this comment.
Excellent analysis. It's a pity that the hierarchy is the widget container is as it is, but I guess is the best we could do provided the big differences between chromium and gecko. At some point we should revisit that for the Chromium case.
I just have to minor nits and then we could land the patch.
app/src/common/shared/com/igalia/wolvic/ui/widgets/KeyboardWidget.java
Outdated
Show resolved
Hide resolved
svillar
changed the title
svillar
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue that Chromium doesn't type nothing in the form. The problem was that the focused view notified from the system is not involved in the window widget which the keyboard widget is attached to. Since Chromium has a content view outside of the windows widget's layer, the focus view could be different with the window widget.
This patch allows asking the soft keyboard from the out side of the window widget.