Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environments tests #1441

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Fix environments tests #1441

merged 3 commits into from
Jun 10, 2024

Conversation

svillar
Copy link
Member

@svillar svillar commented Jun 3, 2024

This PR supersedes #1358. I decided to create a new one instead of pushing commits to the clone repo of the contributor.

HoussemNasri and others added 2 commits June 3, 2024 18:37
It used to fail with the following error
"ERROR: /home/runner/work/wolvic/wolvic/app/build/intermediates/merged_java_res/noapiArm64GeckoGenericRelease/base.jar:
R8: com.android.tools.r8.ResourceException: com.android.tools.r8.internal.Te:
I/O exception while reading '/home/runner/work/wolvic/wolvic/app/build/intermediates/merged_java_res/noapiArm64GeckoGenericRelease/base.jar':
/home/runner/work/wolvic/wolvic/app/build/intermediates/merged_java_res/noapiArm64GeckoGenericRelease/base.jar"
This way the NoAPI flavour would be used to run unit tests for both
ARM64 and x64 architectures.
@svillar svillar force-pushed the fix_environments_tests branch 2 times, most recently from d5866db to 69b6480 Compare June 3, 2024 21:29
Copy link
Collaborator

@felipeerias felipeerias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's great to have a working setup for unit tests.

The values in the test files app/src/test/resources/environments/*.json are not realistic (they use a Mozilla URL) but that's a minor thing that doesn't affect the tests themselves.

@svillar svillar merged commit 5e2900c into main Jun 10, 2024
44 checks passed
@svillar svillar deleted the fix_environments_tests branch June 10, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants