Move prompt dialogs closer to the window and the tray #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeerias
changed the title
felipeerias
force-pushed
the
felipeerias/promptDistance
branch
from
d35ccb6 to
5a9fca7
Compare
|
Screenshot_com igalia wolvic dev_2024 12 19-11 23 21 108_620 This PR moves the list of tabs right next to the tray, making it their connection clearer. |
svillar
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
My main concern is that the list of tabs is no longer at the eye level. It's true that the connection with the tray is evident now, but I worry that the usability would suffer.
It is not a blocker though and maybe a matter of taste. I'll approve this, if you are not planning to change that we could merge it.
Set the Z translation of prompt windows, including the one with the list of tabs, to be the same as the tray.
The Tabs widget is opened from the tray, but currently there isn't a clear visual connection between the two. This PR moves the Tabs widget right next to the tray and also sets as active the associated tray button.
felipeerias
force-pushed
the
felipeerias/promptDistance
branch
from
5a9fca7 to
55d8380
Compare
|
@svillar That's a good point. I have updated the dimensions of the window to make it taller so the most recent tabs fall in the centre of the user's visual field.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the Z translation of prompt windows, including the one with the list of tabs, to be the same as the tray.
The list of tabs is opened from the tray, but currently there isn't a clear visual connection between the two. This PR moves that widget right next to the tray and also sets as active the associated tray button.