Size and spacing of navigation bar elements #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeerias
force-pushed
the
felipeerias/navBarDimensions
branch
from
7b9308d to
e5b05c8
Compare
|
The visual change is noticeable but not large. It can be visualized in this adapted screenshot from Android Studio:
This is how it looks in use:
|
felipeerias
force-pushed
the
felipeerias/navBarDimensions
branch
from
e5b05c8 to
8f5461b
Compare
Set the default size in dp (800dp, previously 720dp) of the navigation bar to be consistent with its default size in world dimensions (4.0). This makes the navigation elements slightly smaller, which we compensate by increasing their size to 44dp. Reduce the margin between elements. Split the styles for the navigation bar from the ones used in other elements in the UI, for example in the close button in dialogs. Increase the height of the navigation bar to ensure that the move bar is visible.
felipeerias
force-pushed
the
felipeerias/navBarDimensions
branch
from
8f5461b to
b061a45
Compare
svillar
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default size in dp (800dp, previously 720dp) of the navigation bar to be consistent with its default size in world dimensions (4.0).
This makes the navigation elements slightly smaller, which we compensate by increasing their size to 44dp.
Reduce the margin between elements.
Ensure that other unrelated parts of the UI are not affected. Split the styles for the navigation bar from the ones used in other elements in the UI, for example in the close button in dialogs.