Disable headlock when in VR videos #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
requested changes
Jan 31, 2025
app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java
Outdated
Show resolved
Hide resolved
app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java
Outdated
Show resolved
Hide resolved
svillar
requested changes
Feb 3, 2025
svillar
requested changes
Feb 3, 2025
app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java
Outdated
Show resolved
Hide resolved
haanhvu
force-pushed
the
issue1698
branch
2 times, most recently
from
02769d6 to
ed2d88e
Compare
svillar
requested changes
Feb 5, 2025
app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java
Outdated
Show resolved
Hide resolved
VR videos are meant for users to be immersed in the whole space around them. Because headlock locks users in the front of them, it needs to be disabled in VR videos. If users enabled headlock before entering VR videos, we disable it when VR videos show and reenable it when they are exited. Fixes Igalia#1698
svillar
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VR videos are meant for users to be immersed in the whole space around them. Because headlock locks users in the front of them, it needs to be disabled in VR videos. If users enabled headlock before entering VR videos, we disable it when VR videos show and reenable it when they are exited.
Fixes #1698