[PicoXR] Added a new interaction profile for the Pico 4 Ultra #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 231ce36.
Pico has defined a input profile for the Pico4U which is different to the ones for the Pico4 or the Pico4E. It is not in any OpenXR doc so we were not aware of it. We got that info from the Pico customer service. The problem was that the runtime was selecting the generic Khronos profile instead of the Pico4 profile because we were not suggesting the specific profile for the 4U but for the 4 (or 4E). Actually the runtime should probably select the Pico4 profile over the generic one but that's their decision anyway.
That interaction profile was used long time ago when the Pico4 device didn't have its own interaction profile. It's actually the profile designed for the Neo3. Recenctly Pico released an extension that provide a specific profile for the Pico4, so this should not be needed. Actually the code was not using it at all, so any device selecting it would be broken.
svillar
force-pushed
the
pico4u_profile
branch
from
1223f35 to
2d7e9c6
Compare
felipeerias
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 4 Ultra has its own interaction profile. It cannot be found in any online sources that we know but we were told about it by the Pico's customer service.
This allows us to remove the workaround that we landed to select the Pico4 profile over the generic Khronos one.
Apart from that, we take the chance to remove the unused Pico4xOld profile, that might potentially break controller support for devices with old PicoOS versions.