Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PICO] Disable the controller when no position info is available #1748

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

felipeerias
Copy link
Collaborator

PICO continuously tracks the controllers even when they are not in use, so we always check for additional hand tracking information.

However, it might happen that the PICO controller has the SPACE_LOCATION_ORIENTATION_VALID flag unset and at the same time we are not able to get hand tracking information.

In that scenario, we should hide the controller.

PICO continuously tracks the controllers even when they are not
in use, so we always check for additional hand tracking
information.

However, it might happen that the PICO controller has the
SPACE_LOCATION_ORIENTATION_VALID flag unset and at the same
time we are not able to get hand tracking information.

In that scenario, we should hide the controller.
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that flow should not be possible in general, but it's for Pico because we do always need to check hand tracking first. Good catch

@svillar svillar merged commit 39f32a6 into main Feb 6, 2025
22 checks passed
@svillar svillar deleted the felipeerias/picoStuckController branch February 6, 2025 09:16
@svillar svillar added the release_candidate PR that should be part of the next release label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_candidate PR that should be part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants