Apply MediaSession fixes to all videos #1752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wolvic has an internal extension which feeds the navigator.mediaSession object with progress information. It was initially developed to get progress information for the progress bar that is shown on fullscreen videos. That's the reason why the extension was only injecting data into the web engine for those videos that were emitting the onfullscreen events. The problem is that in VisionGlass we have another progress bar that is shown in the phone UI but for all videos, not only fullscreen ones. The fix is to capture the playing event and then apply the mediasession fixes that we already have in place for the video element that issued the event. Fixes #1406
felipeerias
requested changes
Feb 14, 2025
There was a problem hiding this comment.
It shows the media bar when the video is not yet in fullscreen, but it does not always hide it when the user navigates away to another page.
For example:
- visit youtube.com
- open the page for a particular video
- the video starts playing, the media bar is show
- click on the "YouTube" logo on the top of the page to go back to youtube.com
- the media bar is still visible
- press play: the previous video resumes playback (it can be heard but not seen)
I have tested this upstream, and it does happen there too, so nothing has changed with this patch (I agree it's a bug anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wolvic has an internal extension which feeds the navigator.mediaSession object with progress information. It was initially developed to get progress information for the progress bar that is shown on fullscreen videos. That's the reason why the extension was only injecting data into the web engine for those videos that were emitting the onfullscreen events.
The problem is that in VisionGlass we have another progress bar that is shown in the phone UI but for all videos, not only fullscreen ones.
The fix is to capture the playing event and then apply the mediasession fixes that we already have in place for the video element that issued the event.
Fixes #1406