Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java e2e tests #12

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Add java e2e tests #12

merged 4 commits into from
Jan 23, 2025

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Jan 23, 2025

This should add e2e test that are based on Java to improve coverage.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (2237399) to head (a52193f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main      #12       +/-   ##
============================================
+ Coverage     1.53%   82.95%   +81.41%     
- Complexity       3      149      +146     
============================================
  Files            8        8               
  Lines          522      522               
  Branches        86       86               
============================================
+ Hits             8      433      +425     
+ Misses         514       72      -442     
- Partials         0       17       +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Member Author

HarelM commented Jan 23, 2025

There is room for improvement when it comes to waterway features that I need to understand, but otherwise, this looks good.

@HarelM HarelM merged commit 3bc7813 into main Jan 23, 2025
4 checks passed
@HarelM HarelM deleted the add-java-e2e branch January 23, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant