Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search #23

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Improve search #23

merged 4 commits into from
Feb 7, 2025

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Feb 5, 2025

The following are added to search only:

  • amenity=place_of_worship
  • shop=bicycle
  • railway=station

water=lake was added to POIs.

Fixed all the logic related to canBeLine and now this is completely ignored.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 99.07407% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.11%. Comparing base (1951add) to head (03fcb97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a/il/org/osm/israelhiking/PlanetSearchProfile.java 99.07% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #23      +/-   ##
============================================
+ Coverage     95.91%   97.11%   +1.20%     
- Complexity      175      197      +22     
============================================
  Files             8        8              
  Lines           563      590      +27     
  Branches         87      101      +14     
============================================
+ Hits            540      573      +33     
+ Misses           13        9       -4     
+ Partials         10        8       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit b7f2321 into main Feb 7, 2025
4 checks passed
@HarelM HarelM deleted the align-search-and-map branch February 7, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant