Optimize the url filter by using non-capturing regex groups #2918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems especially the URL_PATTERN couldn't be optimized by the regex compiler because all groups are capturing.
I was originally looking at the golang ide console speed and there one of the heavy filter plugins is the
GoConsoleFilter
but i can't really update the code to try the differences.But i see the complictated regex where not all matching groups are used. So i suspect this gives a similar issue to the URL regex change i do here.
(this is in the GoConsoleFilter)