-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification balloon #1406
base: main
Are you sure you want to change the base?
Notification balloon #1406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is super good! I've added some minor suggestions as comments and two text fixes as commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments and suggestions
![A notification balloon for a found database connection with an action to connect to it](notification_balloon.png){width=706} | ||
|
||
## Suggestion and timeline notifications | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only described the visual difference of these notification types. I'd suggest adding a short description of their purpose here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example: Use suggestion notification to inform users about important updates and improvements, request feedback, or warn them about potential issues.
Use timeline notifications for showing messages generated by different contexts and processes, such as configuration changes and failed or successful builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listed the same use cases as given in the When to use section. What do you think?
topics/ui/controls/balloon.md
Outdated
|
||
Provide the details on the event or system state to help users decide what to do next: | ||
#### Two lines of body text are visible by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change the title to Collapse long messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will happen automatically so the verb should be passive. Would "Long messages are collapsed" work?
No description provided.