Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification balloon #1406

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Notification balloon #1406

wants to merge 5 commits into from

Conversation

OlyaB
Copy link
Collaborator

@OlyaB OlyaB commented Dec 9, 2024

No description provided.

@OlyaB OlyaB self-assigned this Dec 9, 2024
@eldar-jetbrains eldar-jetbrains self-requested a review December 13, 2024 10:54
Copy link
Collaborator

@eldar-jetbrains eldar-jetbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is super good! I've added some minor suggestions as comments and two text fixes as commits

topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@MariannaKononenko MariannaKononenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and suggestions

![A notification balloon for a found database connection with an action to connect to it](notification_balloon.png){width=706}

## Suggestion and timeline notifications

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only described the visual difference of these notification types. I'd suggest adding a short description of their purpose here as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example: Use suggestion notification to inform users about important updates and improvements, request feedback, or warn them about potential issues.
Use timeline notifications for showing messages generated by different contexts and processes, such as configuration changes and failed or successful builds.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listed the same use cases as given in the When to use section. What do you think?

topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved

Provide the details on the event or system state to help users decide what to do next:
#### Two lines of body text are visible by default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the title to Collapse long messages?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will happen automatically so the verb should be passive. Would "Long messages are collapsed" work?

topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
topics/ui/controls/balloon.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants