feat: add support for question answering model in JSL model handler #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the
langtest/modelhandler/jsl_modelhandler.pyfile. The changes include adding support for a new model type, updating method signatures, and improving the handling of input data.New Model Support:
MedicalQuestionAnsweringto the list of supported models and created a newPretrainedModelForQAclass to handle question-answering tasks. This includes methods for initializing the model, checking if a model instance is supported, and performing predictions. [1] [2] [3]Method Signature Updates:
__call__method inPretrainedJSLModelto accept additional arguments (*argsand**kwargs) and handle dictionary inputs by converting them toHashableDict.Utility Imports:
HashableDictfromlangtest.utils.custom_types.helpersto facilitate the handling of dictionary inputs in the__call__method.These changes enhance the flexibility and functionality of the model handler, particularly for question-answering tasks.