Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Base.operator_associativity of ternary #57165

Merged
merged 3 commits into from
Feb 15, 2025
Merged

fix Base.operator_associativity of ternary #57165

merged 3 commits into from
Feb 15, 2025

Conversation

adienes
Copy link
Contributor

@adienes adienes commented Jan 27, 2025

closes #54637

before:

julia> Base.operator_associativity(:?)
:left

after:

julia> Base.operator_associativity(:?)
:right

@adienes adienes added the bugfix This change fixes an existing bug label Jan 27, 2025
fingolfin
fingolfin approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

(Out of curiosity, us anything using operator_associativity ?)

@fingolfin fingolfin added the merge me PR is reviewed. Merge when all tests are passing label Feb 14, 2025
@giordano giordano merged commit afaff25 into JuliaLang:master Feb 15, 2025
8 checks passed
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base.operator_associativity(:?) incorrectly returns :left
3 participants
@adienes @fingolfin @giordano