[mmtk-julia] Allow building Julia with variations of the binding #57176
+97
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udesou
force-pushed
the
feature/adding-build-flags
branch
2 times, most recently
from
5ec92d1 to
12e2954
Compare
udesou
force-pushed
the
feature/adding-build-flags
branch
from
12e2954 to
47cf1c5
Compare
udesou
changed the title
udesou
force-pushed
the
feature/adding-build-flags
branch
3 times, most recently
from
cab6d06 to
9f53c2c
Compare
qinsoon
reviewed
Jan 28, 2025
udesou
force-pushed
the
feature/adding-build-flags
branch
11 times, most recently
from
45f710e to
a0f5c24
Compare
d-netto
force-pushed
the
feature/adding-build-flags
branch
2 times, most recently
from
7e309a4 to
d7bc72c
Compare
udesou
force-pushed
the
feature/adding-build-flags
branch
2 times, most recently
from
d5b9db2 to
f890322
Compare
udesou
force-pushed
the
feature/adding-build-flags
branch
2 times, most recently
from
1870113 to
51a7abc
Compare
udesou
force-pushed
the
feature/adding-build-flags
branch
5 times, most recently
from
9aac610 to
20d4373
Compare
d-netto
reviewed
Feb 19, 2025
udesou
force-pushed
the
feature/adding-build-flags
branch
3 times, most recently
from
1673f57 to
2ece67b
Compare
udesou
force-pushed
the
feature/adding-build-flags
branch
from
2ece67b to
120a7bf
Compare
d-netto
approved these changes
Feb 20, 2025
Comment on lines
+845
to
858
| ifeq (${USE_THIRD_PARTY_GC},mmtk) | ||
| JCXXFLAGS += -DWITH_THIRD_PARTY_HEAP=1 | ||
| JCFLAGS += -DWITH_THIRD_PARTY_HEAP=1 | ||
|
|
||
| # Must specify a supported MMTk Plan: Immix or StickyImmix | ||
| ifeq (${MMTK_PLAN},Immix) | ||
| JCXXFLAGS += -DMMTK_PLAN_IMMIX | ||
| JCFLAGS += -DMMTK_PLAN_IMMIX | ||
| else ifeq (${MMTK_PLAN},StickyImmix) | ||
| JCXXFLAGS += -DMMTK_PLAN_STICKYIMMIX | ||
| JCFLAGS += -DMMTK_PLAN_STICKYIMMIX | ||
| else | ||
| $(error "Unsupported MMTk plan: $(MMTK_PLAN)") | ||
| $(error "Unsupported MMTk plan: $(MMTK_PLAN). Supported plans: Immix or StickyImmix.") | ||
| endif |
There was a problem hiding this comment.
Perhaps have an else branch in which we throw an "unsupported" error if someone sets the third-party-GC flag to something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables building the mmtk-julia binding with different configurations other than non-moving Immix. While it was already possible to do so when building from source, this should enable using the binaries generated via the latest version from BinaryBuilder (JuliaPackaging/Yggdrasil#10357).
I have also decoupled MMTk from the code, such that it should be an option for a third-party heap. This should be set using
WITH_THIRD_PARTY_GC=mmtk(inMake.useror as an environment variable).The different configurations of MMTk can be achieved by setting the variables below (set in
Make.user, for example):MMTK_PLANMMTK_MOVINGMMTK_BUILDNote that the actual code to support building with moving and sticky immix will be added in future PRs.
I've also added some preliminary documentation in
doc/gc.mdabout building Julia with MMTk, including a link to the binding and an small FAQ on what to do if you break the build of Julia+MMTk.