Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify mathematical definition of gcd #57204

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

LilithHafner
Copy link
Member

See also:

Triage request for this: #57067 (comment)
Similar PR for lcm: #56992

@LilithHafner LilithHafner added docs This change adds or pertains to documentation maths Mathematical functions labels Jan 30, 2025
@LilithHafner LilithHafner merged commit 41a4dfa into master Feb 14, 2025
8 of 9 checks passed
@LilithHafner LilithHafner deleted the LilithHafner-patch-3 branch February 14, 2025 15:56
@LilithHafner LilithHafner added the backport 1.12 Change should be backported to release-1.12 label Feb 14, 2025
@LilithHafner
Copy link
Member Author

Backport so this lands in the same release as #56992

KristofferC pushed a commit that referenced this pull request Feb 14, 2025
See also:

Triage request for this:
#57067 (comment)
Similar PR for `lcm`: #56992

(cherry picked from commit 41a4dfa)
@KristofferC KristofferC mentioned this pull request Feb 15, 2025
31 tasks
KristofferC added a commit that referenced this pull request Feb 17, 2025
Backported PRs:
- [x] #57346 <!-- lowering: Only try to define the method once -->
- [x] #57341 <!-- bpart: When backdating replace the entire bpart chain
-->
- [x] #57381 <!-- staticdata: Set min validation world to require world
-->
- [x] #57357 <!-- Only implicitly `using` Base, not Core -->
- [x] #57383 <!-- staticdata: Fix typo in recursive edge revalidation
-->
- [x] #57385 <!-- bpart: Move kind enum into its intended place -->
- [x] #57275 <!-- Compiler: fix unsoundness of getfield_tfunc on Tuple
Types -->
- [x] #57378 <!-- print admonition for auto-import only once per module
-->
- [x] #57392 <!-- [LateLowerGCFrame] fix PlaceGCFrameReset for
returns_twice -->
- [x] #57388 <!-- Bump JuliaSyntax to v1.0.2 -->
- [x] #57266 <!-- 🤖 [master] Bump the Statistics stdlib from d49c2bf to
77bd570 -->
- [x] #57395 <!-- lowering: fix has_fcall computation -->
- [x] #57204 <!-- Clarify mathematical definition of `gcd` -->
- [x] #56794 <!-- Make `Pairs` public -->
- [x] #57407 <!-- staticdata: corrected implementation of
jl_collect_new_roots -->
- [x] #57405 <!-- bpart: Also partition the export flag -->
- [x] #57420 <!-- Compiler: Fix check for IRShow definedness -->
- [x] #55875 <!-- fix `(-Inf)^-1` inconsistency -->
- [x] #57317 <!-- internals: add _defaultctor function for defining
ctors -->
- [x] #57406 <!-- bpart: Ignore guard bindings for ambiguity purposes
-->
- [x] #49933 <!-- Allow for :foreigncall to transition to GC safe
automatically -->
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation maths Mathematical functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants