Refactoring write barrier for copying generic memory, but moving it from genericmemory.c
#57252
+106
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udesou
force-pushed
the
refactor/wb-genericmemory
branch
4 times, most recently
from
a3fd4d3 to
2713ff1
Compare
Keno
approved these changes
Feb 5, 2025
udesou
force-pushed
the
refactor/wb-genericmemory
branch
5 times, most recently
from
209e7df to
ff20eef
Compare
udesou
force-pushed
the
refactor/wb-genericmemory
branch
5 times, most recently
from
e8f646f to
1f174f2
Compare
udesou
force-pushed
the
refactor/wb-genericmemory
branch
from
1f174f2 to
f288850
Compare
oscardssmith
approved these changes
Feb 19, 2025
udesou
force-pushed
the
refactor/wb-genericmemory
branch
from
f288850 to
0647635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves stock-specific write barriers from
jl_genericmemory_copytointojulia.h. Note that this PR can be merged independently, but is heavily connected with #57237. Ideally they should be combined, but this PR actually introduces new functions to the GC interface, and that is the main reason I'd like them to be reviewed separately. The code for either PR will have to be adapted depending on which one gets merged first.