print admonition for auto-import only once per module #57378
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quiets the build somewhat, after #57311 made it noisy.
Keno
approved these changes
Feb 12, 2025
Keno
reviewed
Feb 12, 2025
| @@ -741,10 +741,11 @@ typedef struct _jl_binding_t { | |||
| _Atomic(jl_binding_partition_t*) partitions; | |||
| jl_array_t *backedges; | |||
| uint8_t did_print_backdate_admonition:1; | |||
| uint8_t did_print_implicit_import_admonition:1; | |||
There was a problem hiding this comment.
https://github.com/JuliaLang/julia/blob/master/base/invalidation.jl#L116 currently assumes the bitposition of the export flag which this changes. I'm about to refactor that code to no longer use the bitset (which is implementation defined anyway), but if you want to merge this change before then, you'll have to adjust one or the other.
There was a problem hiding this comment.
Thanks for the pointer. I will probably just fix the offset for now. Immediately after this PR, I want to change this to an atomics flags field so we can use atomic-and / atomic-or to set these flags safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quiets the build somewhat, after #57311 made it noisy.